Repository navigation
streamResetBurst and streamResetRate options are missing in the documentation of http2.createSecureServer #57169
Description
Activity
Is this open to work on?
- added 2 commits that reference this issue
on Feb 26, 2025 - added a commit that references this issue
on Feb 26, 2025 Note that this merge request did not resolve the wrong typings.
I guess I will create another bug for this.
- added a commit that references this issue
on Mar 9, 2025 - added 2 commits that reference this issue
on Apr 2, 2025 - added 2 commits that reference this issue
on Apr 16, 2025 - added 2 commits that reference this issue
on May 1, 2025
Affected URL(s)
https://nodejs.org/docs/latest/api/http2.html#http2createsecureserveroptions-onrequesthandler
Description of the problem
The new options were added in Node 18.18.2, 20.8.1 und 21.0 to mitigate RST attacks.
It is documented for http2.createServer, but missing in http2.createSecureServer.
I am pretty sure it works for both, because the way createServer and createSecureServer share the code handling the options. It also makes absolutely no sense for them to work for createServer and not for createSecureServer.
The Typescript typings are also wrong. Only createServer typings recognizes streamResetBurst and streamResetRate. If I want to use them for createSecureServer, i have to supress typescript errors for this line and then it seems to work.