Repository navigation
esm loaders: getBuiltin() does not work with node:test #48516
Description
Activity
I assume that it would probably be trivial to add support for the
node:prefix togetBuiltin(), assuming that fixes this, if you want to spend the time. But yeah, the whole sloppy-mode script that seems like CommonJS but isn’t really . . . this is what we’re planning on removing, because of issues like this.cc @nodejs/loaders
Reacted by Colin IhrigI was just looking at that util a couple days ago. It reads/validates from a list;
testis probably just missing from that list. I don't know why it wouldn't be included—oversight or deliberate decision.I expect
register(including the message stuff) to land around mid-July.Reacted by Colin Ihrig- added a commit that references this issue
on Jul 17, 2023 - added 2 commits that reference this issue
on Aug 14, 2023 - added a commit that references this issue
on Aug 14, 2023 - added a commit that references this issue
on Aug 15, 2023 - added a commit that references this issue
on Nov 11, 2023 - added a commit that references this issue
on Nov 23, 2023 - added 2 commits that reference this issue
on Apr 25, 2024
Version
latest main
Platform
all
Subsystem
esm, loaders
What steps will reproduce the bug?
Create an ESM loader, and in the
globalPreload()hook, usegetBuiltin()to accessnode:test(testwithout thenode:scheme also does not work).How often does it reproduce? Is there a required condition?
Always reproduces.
What is the expected behavior? Why is that the expected behavior?
node:testcan be used withgetBuiltin()What do you see instead?
Additional information
I imagine this is related to the use of
BuiltinModule.canBeRequiredWithoutScheme(builtinName)ingetBuiltin().My use case is to attach the message port to the
node:testmodule. For now, I have worked around this by attaching the port toglobalThisinstead. Once nodejs/loaders#147 is resolved, I won't need to do this, but I wanted to raise the issue in case the loaders team thinks it's important.