Repository navigation
http: deprecate/rename finished in favour of ended #28651
Description
Activity
- changed the title
[-]http: deprecate finished in favour of ended alias[/-][+]http: deprecate/rename finished in favour of ended[/+]on Jul 12, 2019 @nodejs/http @nodejs/streams
I'm in favor of a doc-deprecation.
Reacted by Benjamin Gruenbaum and Trivikram KamatThis has been sorted with
writableEndedandwritableFinished. Deprecation is separate thing.- added a commit that references this issue
on Dec 10, 2019 - added a commit that references this issue
on Feb 6, 2020
What is currently the
finishedproperty in http/1 is actually what isendedin the world of streams.Would it be an idea to deprecate
finished(e.g. remove from docs and/or add warning) and add an alias/property calledendedinstead to better match the streams spec and avoid confusion?