Repository navigation
sessions: fix GitHub environment folder picking - #340637
Merged
Merged
Conversation
Separate home-directory filesystem grants, the .copilot browsing default, and local recent-folder catalogue entries. Open the remote folder picker after selecting a GitHub environment and retain its provider identity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
FILE_NOT_DIRECTORY stale recents currently abort sharing instead of being omitted.
1 open finding
What changed in this PR
Separates Mission Control folder browsing, filesystem grants, and project catalogues while improving Agents Window environment selection.
Changes:
- Shares home/project roots and defaults browsing to
~/.copilot. - Synchronizes local recent folders into the remote project catalogue.
- Opens the selected environment’s folder picker with accessibility and regression coverage.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/test/browser/remoteAgentHost/missionControlContribution.test.ts |
Tests sharing roots, catalogues, and defaults. |
src/vs/workbench/contrib/chat/browser/remoteAgentHost/missionControlSharingService.ts |
Builds Mission Control sharing configuration. |
src/vs/sessions/contrib/providers/remoteAgentHost/test/browser/remoteAgentHostActions.test.ts |
Tests environment folder selection. |
src/vs/sessions/contrib/providers/remoteAgentHost/test/browser/missionControlAgentHostContribution.test.ts |
Tests recent-folder publication. |
src/vs/sessions/contrib/providers/remoteAgentHost/REMOTE_AGENT_HOST_SESSIONS_PROVIDER.md |
Documents the new sharing workflow. |
src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHostActions.ts |
Connects environments and opens folder browsing. |
src/vs/sessions/contrib/providers/remoteAgentHost/browser/missionControlAgentHostContribution.ts |
Publishes local recent projects. |
src/vs/sessions/contrib/chat/browser/sessionsChatAccessibilityHelp.ts |
Documents keyboard interaction. |
src/vs/platform/agentHost/test/node/missionControlProtocolServer.test.ts |
Tests live catalogue updates. |
src/vs/platform/agentHost/test/node/missionControlProjects.test.ts |
Tests distinct project roots. |
src/vs/platform/agentHost/test/node/missionControlHost.test.ts |
Tests grants and defaults. |
src/vs/platform/agentHost/node/missionControl/missionControlProjects.ts |
Separates catalogue roots from grants. |
src/vs/platform/agentHost/node/missionControl/missionControlHost.ts |
Wires project roots and browsing defaults. |
src/vs/platform/agentHost/node/missionControl/missionControlEnvironment.ts |
Applies live project updates. |
src/vs/platform/agentHost/common/missionControlEnvironment.ts |
Extends the sharing-service contract. |
src/vs/platform/agentHost/common/agentService.ts |
Adds project and default-directory options. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Skip stale recent folders whose parent is not a directory, and scope environment folder-browsing accessibility help to the feature's availability. Cover both with focused regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
marked this pull request as ready for review
October 9, 2026 02:47
roblourens
enabled auto-merge (squash)
October 9, 2026 02:47
roblourens
marked this pull request as draft
October 9, 2026 02:47
auto-merge was automatically disabled
October 9, 2026 02:47
Pull request was converted to draft
Preserve upstream web Mission Control discovery and accessibility help alongside the recent-folder sharing catalogue and environment folder-picker handoff. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Base:
|
roblourens
marked this pull request as ready for review
October 9, 2026 03:03
roblourens
enabled auto-merge (squash)
October 9, 2026 03:03
Osvaldo Ortega (osortega)
previously approved these changes
Oct 9, 2026
Preserve upstream Mission Control policy overrides and relay recovery while retaining independent filesystem grants, browsing defaults, and recent-folder project catalogues. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ben Villalobos (benvillalobos)
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Unblock testing of local GitHub environments over Mission Control by separating the browsing default, filesystem grants, and project catalogue.
~/.copilotand advertise it as the default directory.Reviewer notes
This intentionally broadens opt-in local Mission Control sharing from workspace-only grants to home-directory access. The grants authorize existing read/write filesystem operations, not just folder navigation. No authentication or remote-control policy bypass is added.
This is a testing-oriented scope/default while the upstream sharing UX is being clarified. The live Windows environment was not exercised with the updated build. Both host and client need the updated build for end-to-end validation.
How to test
~/.copilot, that browsing into another folder under home works, and that accepting a folder selects the correct remote provider..copilotshould not become catalogue entries unless explicitly present in the folder inventory.Validation
npm run build-fast -- --client-only- passed.npm run typecheck-client- passed.npm run valid-layers-check- passed.npm run eslint -- <15 changed TypeScript files>- passed; corrected test fixtures were subsequently linted again.git diff --check- passed.Focused host/sharing/picker suites: 188 passed, 3 skipped:
Existing sharing controls and environment command suites: 38 passed:
Live Windows connection, full integration/smoke suites, and screen-reader testing: not run.
(Written by Copilot)