Skip to content

Fix computeDistanceToActualBaseline throws when accessing child size - #176906

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
bleroux:fix_computeDistanceToActualBaseline_throws_when_accessing_child_size
Oct 14, 2025
Merged

Fix computeDistanceToActualBaseline throws when accessing child size#176906
auto-submit[bot] merged 2 commits into
flutter:masterfrom
bleroux:fix_computeDistanceToActualBaseline_throws_when_accessing_child_size

Conversation

@bleroux

@bleroux bleroux commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fixes an assertion triggered when accessing RenderBox.size during baseline computation.
See #157915 (comment) for context.

Related Issue

Fixes Layout with ListTile -> subtitle -> InputDecorator -> Container (without child) throws RenderBox.size accessed beyond the scope of resize
Fixes DropdownButtonFormField triggers assertion when nested in InputDecorator

Tests

  • Adds 1 test

@github-actions github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 13, 2025
@bleroux bleroux mentioned this pull request Oct 13, 2025
Closed
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 13, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an assertion failure when accessing RenderBox.size during baseline computation by introducing a _debugDoingBaseline flag. The fix is accompanied by a solid regression test that reproduces the issue and verifies the fix. I've suggested a minor style improvement in the test file to make helper classes private, following the Flutter style guide.

Comment thread packages/flutter/test/rendering/box_test.dart Outdated
Comment thread packages/flutter/test/rendering/box_test.dart Outdated
@bleroux
bleroux force-pushed the fix_computeDistanceToActualBaseline_throws_when_accessing_child_size branch from 7e84f41 to 3c40973 Compare October 13, 2025 18:26
LongCatIsLooong
LongCatIsLooong approved these changes Oct 13, 2025
View reviewed changes

@LongCatIsLooong LongCatIsLooong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bleroux
bleroux force-pushed the fix_computeDistanceToActualBaseline_throws_when_accessing_child_size branch from 3c40973 to f7cf56f Compare October 13, 2025 20:06
@bleroux
bleroux force-pushed the fix_computeDistanceToActualBaseline_throws_when_accessing_child_size branch from f7cf56f to f0b80bb Compare October 14, 2025 03:54
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 14, 2025
@auto-submit
auto-submit Bot added this pull request to the merge queue Oct 14, 2025
Merged via the queue into flutter:master with commit 7cd821c Oct 14, 2025
77 of 78 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 14, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025
@engine-flutter-autoroll
7cd821c Fix computeDistanceToActualBaseline throws when accessing chi…
f606a0d 
…ld size (flutter/flutter#176906)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 14, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025
@engine-flutter-autoroll
7cd821c Fix computeDistanceToActualBaseline throws when accessing chi…
cd0b9c1 
…ld size (flutter/flutter#176906)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025
@engine-flutter-autoroll
7cd821c Fix computeDistanceToActualBaseline throws when accessing chi…
93aef3c 
…ld size (flutter/flutter#176906)
@bleroux
bleroux deleted the fix_computeDistanceToActualBaseline_throws_when_accessing_child_size branch October 14, 2025 20:30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 15, 2025
@engine-flutter-autoroll
7cd821c Fix computeDistanceToActualBaseline throws when accessing chi…
4c7ac55 
…ld size (flutter/flutter#176906)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 15, 2025
@engine-flutter-autoroll
7cd821c Fix computeDistanceToActualBaseline throws when accessing chi…
53fb564 
…ld size (flutter/flutter#176906)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Oct 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from e11e2c1 to 7cd821c (73 revisions) (#10229)
aed47f1 
Manual roll Flutter from e11e2c1 to 7cd821c (73 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@e11e2c1...7cd821c

2025-10-14 bruno.leroux@gmail.com Fix computeDistanceToActualBaseline throws when accessing child size (flutter/flutter#176906)
2025-10-14 47866232+chunhtai@users.noreply.github.com iOS can set application locale before view controller is set (flutter/flutter#176592)
2025-10-14 jason-simmons@users.noreply.github.com Roll ANGLE to a branch based on d9fa255a5c22 (flutter/flutter#176747)
2025-10-14 47866232+chunhtai@users.noreply.github.com Relands "Fixes keyboard selects disabled radio" (flutter/flutter#176977)
2025-10-14 huy@nevercode.io Fix expansion tile is missing state announcement on non-Apple platforms (flutter/flutter#175480)
2025-10-14 30870216+gaaclarke@users.noreply.github.com impeller: allows access of float uniforms by name (flutter/flutter#176728)
2025-10-14 aam@google.com Roll dart sdk to 3.11.0-17.0.dev (flutter/flutter#176947)
2025-10-13 okorohelijah@google.com Move iOS integration tests (flutter/flutter#176940)
2025-10-13 ahmedsameha1@gmail.com Make sure that an InputDatePickerFormField doesn't crash in 0x0 envir… (flutter/flutter#176047)
2025-10-13 jason-simmons@users.noreply.github.com [web] Match the behavior of other platforms in Web Locale.toString if the country code is an empty string (flutter/flutter#176862)
2025-10-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fixes keyboard selects disabled radio (#176727)" (flutter/flutter#176958)
2025-10-13 47866232+chunhtai@users.noreply.github.com Fixes keyboard selects disabled radio (flutter/flutter#176727)
2025-10-13 engine-flutter-autoroll@skia.org Roll Packages from e319c40 to d062181 (2 revisions) (flutter/flutter#176916)
2025-10-13 jason-simmons@users.noreply.github.com Roll SwiftShader to 794b0cfce1d8 (flutter/flutter#176806)
2025-10-13 32538273+ValentinVignal@users.noreply.github.com Make DropdownMenu generic type non nullable (flutter/flutter#176711)
2025-10-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from BWGpRvpdQh-HJpq1c... to _dd0Jv50H0oUI2Ad8... (flutter/flutter#176895)
2025-10-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from JpiUsek1hU5r9QVKP... to BWGpRvpdQh-HJpq1c... (flutter/flutter#176880)
2025-10-11 codefu@google.com fix: content hash check for LUCI_CONTEXT (flutter/flutter#176867)
2025-10-11 34465683+rkishan516@users.noreply.github.com Feat: make tooltip position customizeable (flutter/flutter#175047)
2025-10-11 engine-flutter-autoroll@skia.org Roll Dart SDK from d88d8bf2b53c to 65b171958c93 (3 revisions) (flutter/flutter#176871)
2025-10-11 34465683+rkishan516@users.noreply.github.com feat: apply radioGroup role to segmented control widgets (flutter/flutter#176157)
2025-10-10 ahmedsameha1@gmail.com Make sure that a CheckboxMenuButton doesn't crash in 0x0 environment (flutter/flutter#176450)
2025-10-10 Rusino@users.noreply.github.com [WebParagraph] Support for more styles, placeholders, decorations, etc (flutter/flutter#172853)
2025-10-10 jason-simmons@users.noreply.github.com Set up a version of build_ios_framework_module_test that only runs on x64 machines and extend its timeout (flutter/flutter#176811)
2025-10-10 engine-flutter-autoroll@skia.org Roll Packages from 0b41de3 to e319c40 (1 revision) (flutter/flutter#176833)
2025-10-10 danny@tuppeny.com [tool/dap] Forward app.warning events from Flutter to DAP client (flutter/flutter#176827)
2025-10-10 engine-flutter-autoroll@skia.org Roll Dart SDK from 70c00d3ceb3a to d88d8bf2b53c (1 revision) (flutter/flutter#176830)
2025-10-10 sokolovskyi.konstantin@gmail.com Remove unnecessary nullable types in examples. (flutter/flutter#176713)
2025-10-10 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xArtL4DH0FsdwSqG_... to JpiUsek1hU5r9QVKP... (flutter/flutter#176822)
2025-10-10 bruno.leroux@gmail.com Cleanup OutlinedButton.icon documentation and implementation (flutter/flutter#176630)
2025-10-10 34871572+gmackall@users.noreply.github.com [HCPP] Properly remove hcpp views that are no longer visible (flutter/flutter#176742)
2025-10-10 ahmedsameha1@gmail.com Make sure that an InputChip doesn't crash in 0x0 environment (flutter/flutter#175930)
2025-10-10 737941+loic-sharma@users.noreply.github.com Update Flutter templates' Dart style (flutter/flutter#175963)
2025-10-10 ahmedsameha1@gmail.com Make sure that a DropdownButtonFormField doesn't crash in 0x0 environ… (flutter/flutter#174958)
2025-10-10 ahmedsameha1@gmail.com Make sure that an InkWell doesn't crash in 0x0 environment (flutter/flutter#175871)
2025-10-10 ahmedsameha1@gmail.com Handle#6537 end drawer button (flutter/flutter#173026)
2025-10-10 engine-flutter-autoroll@skia.org Roll Dart SDK from a9b7bd4b0b32 to 70c00d3ceb3a (4 revisions) (flutter/flutter#176815)
2025-10-10 robert.ancell@canonical.com Change default Linux thread policy to merge platform and UI threads. (flutter/flutter#176759)
2025-10-09 bkonyi@google.com [ Tool ] Roll package:dwds to 26.0.0 (flutter/flutter#176808)
2025-10-09 43054281+camsim99@users.noreply.github.com Update `CHANGELOG` to include 3.35.6 notes (flutter/flutter#176803)
2025-10-09 36861262+QuncCccccc@users.noreply.github.com Announce text and button together when DropdownMenu is treated as a button (flutter/flutter#176428)
2025-10-09 gregorysconrad@gmail.com [native_assets] create macOS CCompilerConfig via xcrun --find (flutter/flutter#175717)
2025-10-09 chinmaygarde@google.com [Impeller] Fix broken links in README. (flutter/flutter#176770)
2025-10-09 chinmaygarde@google.com Fix links to Custom Flutter Engine Embedders in README. (flutter/flutter#175807)
...
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
@bleroux @reidbaker
Fix computeDistanceToActualBaseline throws when accessing child size (f…
fdd57b4 
…lutter#176906)

## Description

This PR fixes an assertion triggered when accessing `RenderBox.size`
during baseline computation.
See
flutter#157915 (comment)
for context.

## Related Issue

Fixes [Layout with ListTile -> subtitle -> InputDecorator -> Container
(without child) throws RenderBox.size accessed beyond the scope of
resize](flutter#157915)
Fixes [DropdownButtonFormField triggers assertion when nested in
InputDecorator](flutter#176696 (comment))

## Tests

- Adds 1 test
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026
@engine-flutter-autoroll
7cd821c Fix computeDistanceToActualBaseline throws when accessing chi…
cdea464 
…ld size (flutter/flutter#176906)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Manual roll Flutter from e11e2c1 to 7cd821c (73 revisions) (flutter#1…
d600910 
…0229)

Manual roll Flutter from e11e2c1 to 7cd821c (73 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@e11e2c1...7cd821c

2025-10-14 bruno.leroux@gmail.com Fix computeDistanceToActualBaseline throws when accessing child size (flutter/flutter#176906)
2025-10-14 47866232+chunhtai@users.noreply.github.com iOS can set application locale before view controller is set (flutter/flutter#176592)
2025-10-14 jason-simmons@users.noreply.github.com Roll ANGLE to a branch based on d9fa255a5c22 (flutter/flutter#176747)
2025-10-14 47866232+chunhtai@users.noreply.github.com Relands "Fixes keyboard selects disabled radio" (flutter/flutter#176977)
2025-10-14 huy@nevercode.io Fix expansion tile is missing state announcement on non-Apple platforms (flutter/flutter#175480)
2025-10-14 30870216+gaaclarke@users.noreply.github.com impeller: allows access of float uniforms by name (flutter/flutter#176728)
2025-10-14 aam@google.com Roll dart sdk to 3.11.0-17.0.dev (flutter/flutter#176947)
2025-10-13 okorohelijah@google.com Move iOS integration tests (flutter/flutter#176940)
2025-10-13 ahmedsameha1@gmail.com Make sure that an InputDatePickerFormField doesn't crash in 0x0 envir… (flutter/flutter#176047)
2025-10-13 jason-simmons@users.noreply.github.com [web] Match the behavior of other platforms in Web Locale.toString if the country code is an empty string (flutter/flutter#176862)
2025-10-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fixes keyboard selects disabled radio (#176727)" (flutter/flutter#176958)
2025-10-13 47866232+chunhtai@users.noreply.github.com Fixes keyboard selects disabled radio (flutter/flutter#176727)
2025-10-13 engine-flutter-autoroll@skia.org Roll Packages from e319c40 to d062181 (2 revisions) (flutter/flutter#176916)
2025-10-13 jason-simmons@users.noreply.github.com Roll SwiftShader to 794b0cfce1d8 (flutter/flutter#176806)
2025-10-13 32538273+ValentinVignal@users.noreply.github.com Make DropdownMenu generic type non nullable (flutter/flutter#176711)
2025-10-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from BWGpRvpdQh-HJpq1c... to _dd0Jv50H0oUI2Ad8... (flutter/flutter#176895)
2025-10-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from JpiUsek1hU5r9QVKP... to BWGpRvpdQh-HJpq1c... (flutter/flutter#176880)
2025-10-11 codefu@google.com fix: content hash check for LUCI_CONTEXT (flutter/flutter#176867)
2025-10-11 34465683+rkishan516@users.noreply.github.com Feat: make tooltip position customizeable (flutter/flutter#175047)
2025-10-11 engine-flutter-autoroll@skia.org Roll Dart SDK from d88d8bf2b53c to 65b171958c93 (3 revisions) (flutter/flutter#176871)
2025-10-11 34465683+rkishan516@users.noreply.github.com feat: apply radioGroup role to segmented control widgets (flutter/flutter#176157)
2025-10-10 ahmedsameha1@gmail.com Make sure that a CheckboxMenuButton doesn't crash in 0x0 environment (flutter/flutter#176450)
2025-10-10 Rusino@users.noreply.github.com [WebParagraph] Support for more styles, placeholders, decorations, etc (flutter/flutter#172853)
2025-10-10 jason-simmons@users.noreply.github.com Set up a version of build_ios_framework_module_test that only runs on x64 machines and extend its timeout (flutter/flutter#176811)
2025-10-10 engine-flutter-autoroll@skia.org Roll Packages from 0b41de3 to e319c40 (1 revision) (flutter/flutter#176833)
2025-10-10 danny@tuppeny.com [tool/dap] Forward app.warning events from Flutter to DAP client (flutter/flutter#176827)
2025-10-10 engine-flutter-autoroll@skia.org Roll Dart SDK from 70c00d3ceb3a to d88d8bf2b53c (1 revision) (flutter/flutter#176830)
2025-10-10 sokolovskyi.konstantin@gmail.com Remove unnecessary nullable types in examples. (flutter/flutter#176713)
2025-10-10 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xArtL4DH0FsdwSqG_... to JpiUsek1hU5r9QVKP... (flutter/flutter#176822)
2025-10-10 bruno.leroux@gmail.com Cleanup OutlinedButton.icon documentation and implementation (flutter/flutter#176630)
2025-10-10 34871572+gmackall@users.noreply.github.com [HCPP] Properly remove hcpp views that are no longer visible (flutter/flutter#176742)
2025-10-10 ahmedsameha1@gmail.com Make sure that an InputChip doesn't crash in 0x0 environment (flutter/flutter#175930)
2025-10-10 737941+loic-sharma@users.noreply.github.com Update Flutter templates' Dart style (flutter/flutter#175963)
2025-10-10 ahmedsameha1@gmail.com Make sure that a DropdownButtonFormField doesn't crash in 0x0 environ… (flutter/flutter#174958)
2025-10-10 ahmedsameha1@gmail.com Make sure that an InkWell doesn't crash in 0x0 environment (flutter/flutter#175871)
2025-10-10 ahmedsameha1@gmail.com Handle#6537 end drawer button (flutter/flutter#173026)
2025-10-10 engine-flutter-autoroll@skia.org Roll Dart SDK from a9b7bd4b0b32 to 70c00d3ceb3a (4 revisions) (flutter/flutter#176815)
2025-10-10 robert.ancell@canonical.com Change default Linux thread policy to merge platform and UI threads. (flutter/flutter#176759)
2025-10-09 bkonyi@google.com [ Tool ] Roll package:dwds to 26.0.0 (flutter/flutter#176808)
2025-10-09 43054281+camsim99@users.noreply.github.com Update `CHANGELOG` to include 3.35.6 notes (flutter/flutter#176803)
2025-10-09 36861262+QuncCccccc@users.noreply.github.com Announce text and button together when DropdownMenu is treated as a button (flutter/flutter#176428)
2025-10-09 gregorysconrad@gmail.com [native_assets] create macOS CCompilerConfig via xcrun --find (flutter/flutter#175717)
2025-10-09 chinmaygarde@google.com [Impeller] Fix broken links in README. (flutter/flutter#176770)
2025-10-09 chinmaygarde@google.com Fix links to Custom Flutter Engine Embedders in README. (flutter/flutter#175807)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

2 participants

@bleroux @LongCatIsLooong