Repository navigation
Use new ScreenControllers class for controller lifecycle management - #8908
Merged
Merged
Conversation
kenzieschmoll
requested review from
a team,
bkonyi and
elliette
as code owners
February 19, 2025 00:28
elliette
reviewed
Feb 19, 2025
elliette
reviewed
Feb 19, 2025
elliette
reviewed
Feb 19, 2025
elliette
approved these changes
Feb 19, 2025
elliette
reviewed
Feb 19, 2025
elliette
reviewed
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to use
package:providerto manage the lifecycle of the DevTools screen controllers, andProvidedControllerMixinas a way to easily initialize and access these controllers. This caused lifecycle management issues and memory leaks because the screen controllers (which are expected to be long living) were tied to the widget lifecycle, since lookup controllers up frompackage:providerrequires access toBuildContext.This PR creates a class
ScreenControllersthat is accessible from a globalscreenControllers. Individual screen controllers are still created lazily upon first access, and can be accessed from anywhere (widget code or business logic) by callingscreenControllers.lookup<ControllerType>().This PR also deletes the
ProvidedControllerMixinsince it is no longer needed.